WIP feat: initial r/profile dapp #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul-bot
force-pushed
the
dev/moul/r/profiles
branch
2 times, most recently
from
d78eed8
to
a8d63fa
Compare
moul-bot
force-pushed
the
dev/moul/r/profiles
branch
from
370b2ef
to
fc1713d
Compare
moul-bot
force-pushed
the
dev/moul/r/profiles
branch
from
6109e2b
to
fe6690d
Compare
moul-bot
force-pushed
the
dev/moul/r/profiles
branch
from
0c86475
to
205ea11
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul-bot
force-pushed
the
dev/moul/r/profiles
branch
from
205ea11
to
7dd0047
Compare
|
Are you still interested in working on this? Shall we keep it open? @moul |
|
Yes, I will continue. |
moul
commented
Aug 3, 2023
|
|
||
| // TODO: makes sense to implement an allowance system? | ||
|
|
||
| var profiles *avl.MutTree // std.Address.String() -> *Profile |
|
Quick update: -> https://medium.com/@matryer/context-keys-in-go-5312346a868d |
|
ping @gnolang/24-zone01-1 |
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Following this [PR](gnolang#181 (comment)) concerning the creation of a realm `profile` I created this realm which allows the creation of profile as well as the associated functions to display the information of a profile with an address or a username. I have some questions concerning this realm: - Currently, if a user modifies his username, his old username is not freed and is therefore no longer available, even if it is no longer in use. Should I free the old username when the user has changed username? - To make it possible to search by username and address, I've created a second avl tree containing both username and address, so that I can find the profile indexed by its address by searching for it by its username. This is the most efficient solution I've found. I'd like to get some feedback on this and know if I should do things differently so that searching by username is more optimized. - Do you have any other suggestions for completing the profile fields, or other interesting features to add? Thanks in advance for your feedback <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Closes gnolang#181 --------- Co-authored-by: kazai <kazai@777> Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to let users define custom metadata that can be reused across
the whole ecosystem.
This realm is intended to be used by people that owns a r/user entry or
not (works well with just an
std.Address).This is a preliminary realm for bigger projects that would to rely on Gno,
including a twitter clone, or maybe an ENS that could store IP addresses, etc.
The goal is to pack the contract with default fields that are the expected most common ones for customization (profile_picture, name, primary_color, is_dev (to enable more debug), etc. But the contract should support a way to set new fields, basically a key/value store associated with a profile.
Exected usage API from another contract:
Depends on #145
Depends on #149